Fix race condition when multiple targets utilize the same local property name#4
Open
mharmer wants to merge 1 commit intocodeaholics:masterfrom
Open
Fix race condition when multiple targets utilize the same local property name#4mharmer wants to merge 1 commit intocodeaholics:masterfrom
mharmer wants to merge 1 commit intocodeaholics:masterfrom
Conversation
…fore invoking the target. This is similar to how the parallel Ant task performs this, and ensures that two targets running at the same time don't race on the previously shared local properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change applies the same technique used in the core Ant Parallel Task source to ensure a copy of the LocalProperties is made before the target is executed.
Prior to this, two or more targets that set local property values would actually be sharing the same property rather than their own copies. This would cause race conditions on the property values (one target could write a value that another would see) when running with Parallel-Ant.