Support for installing rdb-tools under io.js (possibly also Node 0.12)#5
Closed
assaf wants to merge 3 commits intocodeaholics:masterfrom
Closed
Support for installing rdb-tools under io.js (possibly also Node 0.12)#5assaf wants to merge 3 commits intocodeaholics:masterfrom
assaf wants to merge 3 commits intocodeaholics:masterfrom
Conversation
Owner
|
Thanks for this. I've not started looking into io.js (or Node 0.12) yet. But I notice this PR fails on Travis. So my questions are...
|
Author
|
This PR uses nan, so the code should build on all versions of Node 0.8 or later, and all versions of io.js. int64-native will not install on 0.12 or later, and the alternative int64-native-node12 seem to be written for 0.12 or later only (won't install on 0.10). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes we needed to build rdb-tools with io.js. It should also apply to Node 0.12, but we only tested our fork against io.js (2.2.x and later).
int64-native-node12, a fork ofint64-nativethat builds on Node 0.12/io.jslzf, which builds on io.js ((there's a separate PR to merge those changes back intolzf)