Skip to content

Conversation

@raphael-goetz
Copy link
Member

Resolves: #205

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reworks the action-related protobuf APIs to remove duplicated RPCs by extracting action configuration into a shared type and introducing dedicated ActionConfiguration services.

Changes:

  • Added shared.ActionConfiguration message type in shared protos.
  • Added ActionConfigurationService protos for both sagittarius and aquila.
  • Simplified Aquila action transfer “first message” from a full configuration payload to a logon identifier/version message; removed the old Sagittarius ActionService proto and updated README structure.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
proto/shared/shared.action_configuration.proto Introduces a shared ActionConfiguration message to centralize action config types.
proto/sagittarius/sagittarius.action_configuration.proto Adds Sagittarius-side ActionConfiguration update RPC definitions.
proto/sagittarius/sagittarius.action.proto Removes the old Sagittarius ActionService (logon/logoff) proto.
proto/aquila/aquila.action_configuration.proto Adds Aquila-side ActionConfiguration update RPC definitions (currently has namespace/import issues).
proto/aquila/aquila.action.proto Reworks the initial transfer message from “Configuration” to “ActionLogon”.
README.md Updates documentation to reflect new action_configuration services and shared type.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

raphael-goetz and others added 4 commits January 30, 2026 13:15
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Duplicate rpc and use existing ones for actions

2 participants