-
Notifications
You must be signed in to change notification settings - Fork 0
Rework Action Service #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Reworks the action-related protobuf APIs to remove duplicated RPCs by extracting action configuration into a shared type and introducing dedicated ActionConfiguration services.
Changes:
- Added
shared.ActionConfigurationmessage type in shared protos. - Added
ActionConfigurationServiceprotos for bothsagittariusandaquila. - Simplified Aquila action transfer “first message” from a full configuration payload to a logon identifier/version message; removed the old Sagittarius
ActionServiceproto and updated README structure.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| proto/shared/shared.action_configuration.proto | Introduces a shared ActionConfiguration message to centralize action config types. |
| proto/sagittarius/sagittarius.action_configuration.proto | Adds Sagittarius-side ActionConfiguration update RPC definitions. |
| proto/sagittarius/sagittarius.action.proto | Removes the old Sagittarius ActionService (logon/logoff) proto. |
| proto/aquila/aquila.action_configuration.proto | Adds Aquila-side ActionConfiguration update RPC definitions (currently has namespace/import issues). |
| proto/aquila/aquila.action.proto | Reworks the initial transfer message from “Configuration” to “ActionLogon”. |
| README.md | Updates documentation to reflect new action_configuration services and shared type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Resolves: #205