Change flow setting object conversion to use Value.from_ruby #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Knerio wants to merge 2 commits into main from change-object-to-value

Member

Knerio commented Jan 28, 2026

No description provided.


          Change object conversion to use Value.from_ruby

d78a065

Signed-off-by: Dario Pranjic <96529060+Knerio@users.noreply.github.com>

Knerio requested a review from Taucher2003

January 28, 2026 14:16

Knerio self-assigned this

Knerio changed the title ~~Change object conversion to use Value.from_ruby~~ Change flow setting object conversion to use Value.from_ruby

github-actions bot commented Jan 28, 2026 •

edited

Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2291856245

Status: Failed
Duration: 5 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12898848465/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2291856245/test_report
Finished in 23.87 seconds (files took 11.05 seconds to load)
1322 examples, 1 failure
Line Coverage: 91.63% (4597 / 5017)
[TEST PROF INFO] Time spent in factories: 00:13.158 (42.98% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12898848463/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2291856245/test_report
Finished in 23.84 seconds (files took 10.48 seconds to load)
1275 examples, 1 failure
Line Coverage: 91.09% (4429 / 4862)
[TEST PROF INFO] Time spent in factories: 00:12.780 (42.16% of total time)

rubocop

736 files inspected, no offenses detected


          Rename 'object' to 'value' in to_grpc method

ecc910e

Signed-off-by: Dario Pranjic <96529060+Knerio@users.noreply.github.com>

Knerio closed this

Knerio deleted the change-object-to-value branch

January 28, 2026 15:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet