Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/components/d-flow-data-type/DFlowDataType.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,20 @@ import {
DataTypeIdentifier,
DataTypeRule,
DataTypeRulesContainsKeyConfig,
DataTypeRulesInputTypesConfig, Flow,
DataTypeRulesInputTypesConfig,
Flow,
GenericMapper,
LiteralValue,
Maybe, Namespace, NamespaceProject,
NodeParameterValue, Runtime,
Maybe,
Namespace,
NamespaceProject,
NodeFunctionIdWrapper,
NodeParameterValue,
Runtime,
Scalars
} from "@code0-tech/sagittarius-graphql-types";
import {useValueValidation} from "../d-flow-validation/DValueValidation.hook";
import {findReturnNode} from "./rules/DFlowDataTypeReturnTypeRule";

export type DFlowDataTypeDependencies = {
namespaceId: Namespace['id']
Expand Down Expand Up @@ -103,8 +109,15 @@ export abstract class DFlowDataTypeReactiveService extends ReactiveArrayService<
if (ruleThatIncludesGenericKey
&& ruleThatIncludesGenericKey.variant == "RETURN_TYPE"
&& dataType.variant === "NODE") {

const foundReturnFunction = findReturnNode(value as NodeFunctionIdWrapper, flow!!)
const returnValue = foundReturnFunction?.parameters?.nodes?.[0]?.value;

return {
sourceDataTypeIdentifiers: [this.getTypeFromValue(value, flow, dependencies)],
sourceDataTypeIdentifiers: [this.getTypeFromValue(returnValue ?? {
__typename: "LiteralValue",
value: null
}, flow, dependencies)],
target: genericKey
} as GenericMapper
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type {DataTypeRulesRegexConfig, NodeParameterValue} from "@code0-tech/sag
@staticImplements<DFlowDataTypeRule>()
export class DFlowDataTypeRegexRule {
public static validate(value: NodeParameterValue, config: DataTypeRulesRegexConfig): boolean {
if (value.__typename != 'LiteralValue') return false
if (value?.__typename != 'LiteralValue') return false
if (!config.pattern) return false
return new RegExp(config.pattern).test(String(value.value))
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,11 @@ export class DFlowDataTypeReturnTypeRule {

if (value.__typename != "NodeFunctionIdWrapper") return false

if (config?.dataTypeIdentifier?.genericKey && !genericMapper && !service?.getDataType(config.dataTypeIdentifier)) return true

const foundReturnFunction = findReturnNode(value, flow!!)
if (!foundReturnFunction) return false

if (config?.dataTypeIdentifier?.genericKey && !genericMapper && !service?.getDataType(config.dataTypeIdentifier)) return true
if (!foundReturnFunction?.parameters?.nodes?.[0]?.value) return false

if (!(service?.getDataType(config.dataTypeIdentifier!!) || genericMapper)) return false

Expand All @@ -43,13 +44,13 @@ export class DFlowDataTypeReturnTypeRule {
//check if all generic combinations are set
if (genericMapper && !(((genericCombination?.length ?? 0) + 1) == genericTypes!!.length)) return false

if (foundReturnFunction?.parameters?.nodes!![0]?.value!!.__typename === "ReferenceValue") {
if (foundReturnFunction?.parameters?.nodes?.[0]?.value?.__typename === "ReferenceValue") {

//use generic given type for checking against value
if (config?.dataTypeIdentifier?.genericKey && genericMapper && genericTypes) {

const checkAllTypes: boolean[] = genericTypes.map(genericType => {
return useDataTypeValidation(service?.getDataType(genericType)!!, service?.getDataType((foundReturnFunction?.parameters?.nodes!![0]?.value!! as ReferenceValue).dataTypeIdentifier!!)!!)
return useDataTypeValidation(service?.getDataType(genericType)!!, service?.getDataType((foundReturnFunction?.parameters?.nodes?.[0]?.value as ReferenceValue).dataTypeIdentifier!)!)
})

return checkAllTypes.length > 1 ? checkAllTypes.reduce((previousValue, currentValue, currentIndex) => {
Expand All @@ -62,18 +63,18 @@ export class DFlowDataTypeReturnTypeRule {
}

if (config?.dataTypeIdentifier?.dataType) {
return useDataTypeValidation(service?.getDataType(config.dataTypeIdentifier!!)!!, service?.getDataType(foundReturnFunction?.parameters?.nodes!![0]?.value?.dataTypeIdentifier!!)!!)
return useDataTypeValidation(service?.getDataType(config.dataTypeIdentifier!)!, service?.getDataType(foundReturnFunction?.parameters?.nodes?.[0]?.value?.dataTypeIdentifier!)!)
}

} else if (foundReturnFunction?.parameters?.nodes!![0]?.value?.__typename == "NodeFunctionIdWrapper") {
} else if (foundReturnFunction?.parameters?.nodes?.[0]?.value?.__typename == "NodeFunctionIdWrapper") {
//TODO : allow function as return value
} else {

//use generic given type for checking against value
if (config?.dataTypeIdentifier?.genericKey && genericMapper && genericTypes) {

const checkAllTypes: boolean[] = genericTypes.map(genericType => {
return useValueValidation(foundReturnFunction?.parameters?.nodes!![0]?.value!!, service?.getDataType(genericType)!!, service!!, flow, ((genericType.genericType as GenericType)!!.genericMappers as GenericMapper[]))
return useValueValidation(foundReturnFunction?.parameters?.nodes?.[0]?.value!, service?.getDataType(genericType)!!, service!!, flow, ((genericType.genericType as GenericType)!!.genericMappers as GenericMapper[]))
})

return checkAllTypes.length > 1 ? checkAllTypes.reduce((previousValue, currentValue, currentIndex) => {
Expand All @@ -86,10 +87,10 @@ export class DFlowDataTypeReturnTypeRule {
}

if (config?.dataTypeIdentifier?.dataType) {
return useValueValidation(foundReturnFunction?.parameters?.nodes!![0]?.value!!, service?.getDataType(config.dataTypeIdentifier!!)!!, service!!)
return useValueValidation(foundReturnFunction?.parameters?.nodes?.[0]?.value!, service?.getDataType(config.dataTypeIdentifier!)!, service!!)
}

return useValueValidation(foundReturnFunction?.parameters?.nodes!![0]?.value!!, service?.getDataType(config.dataTypeIdentifier!!)!!, service!!, flow, genericMapping(config.dataTypeIdentifier?.genericType?.genericMappers!!, generics))
return useValueValidation(foundReturnFunction?.parameters?.nodes?.[0]?.value!, service?.getDataType(config.dataTypeIdentifier!)!, service!!, flow, genericMapping(config.dataTypeIdentifier?.genericType?.genericMappers!, generics))

}

Expand All @@ -98,13 +99,14 @@ export class DFlowDataTypeReturnTypeRule {
}
}

const findReturnNode = (n: NodeFunctionIdWrapper, flow: Flow): NodeFunction | undefined => {
export const findReturnNode = (n: NodeFunctionIdWrapper, flow: Flow): NodeFunction | undefined => {


const node = flow.nodes?.nodes?.find(node => node?.id === n.id) as NodeFunction | undefined
if (node?.functionDefinition?.runtimeFunctionDefinition?.identifier === 'RETURN') return node
if (!node) return undefined
if (node?.functionDefinition?.runtimeFunctionDefinition?.identifier === 'std::control::return') return node

if (node) {
if (node && node.nextNodeId) {
const found = findReturnNode({
id: node.nextNodeId,
__typename: "NodeFunctionIdWrapper"
Expand Down