Remove AppDelegate memory leak in Android projects#174
Open
rynkowsg wants to merge 2 commits intococos2d-x:v3from
Open
Remove AppDelegate memory leak in Android projects#174rynkowsg wants to merge 2 commits intococos2d-x:v3from
rynkowsg wants to merge 2 commits intococos2d-x:v3from
Conversation
added 2 commits
August 6, 2016 10:14
- removed redundant headers (reduced dependencies) - removed redundant code - corrected code style
AppDelegate object and all its members are never released. As a solution I propose to use static unique_ptr that could destroy it at the end of the application. Issue: cocos2d/cocos2d-x#14110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppDelegate object and all its members are never released.
As a solution, I proposed to use static
unique_ptrthat could destroy it at the end of the application.Before applying the aforementioned fix I corrected also code style and correctness of
main.cppfiles in Android projects: