Issue 21031 #229
Open
Issue 21031 #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary with Python 3.14 so the function returned by `partial`
doesn't won't be passed the `self` when called as a member of the
DistRDF base class.
Fixes failures like these:
```txt
=================================== FAILURES ===================================
_________________ TestInitialization.test_initialization[dask] _________________
self = <check_backend.TestInitialization object at 0x7f0248aea5d0>
payload = (<Client: 'tcp://127.0.0.1:45111' processes=2 threads=2, memory=4.00 GiB>, 'dask')
def test_initialization(self, payload):
"""
Check that the user initialization method is assigned to the current
backend.
"""
connection, _ = payload
def returnNumber(n):
return n
DistRDF.initialize(returnNumber, 123)
df = ROOT.RDataFrame(10, executor=connection)
# Dummy df just to retrieve the initialization function
f = df._headnode.backend.initialization
> assert f() == 123
^^^
E TypeError: TestInitialization.test_initialization.<locals>.returnNumber() takes 1 positional argument but 2 were given
../../../../../src/roottest/python/distrdf/backends/check_backend.py:81: TypeError
```
This is to test distributed RDataFrame also on a platform with Python 3.14. Also remove some unneeded configuration flags, because they don't deviate from `global.txt`.
This is to avoid a warning when running the tutorials:
```txt
Processing /github/home/ROOT-CI/src/tutorials/machine_learning/TMVA_SOFIE_GNN_Application.C...
In file included from input_line_10:1:
##[error]/github/home/ROOT-CI/src/tutorials/machine_learning/TMVA_SOFIE_GNN_Application.C:14:10: fatal error: 'encoder.hxx' file not found
#include "encoder.hxx"
^~~~~~~~~~~~~
##[error]/github/home/ROOT-CI/src/tutorials/machine_learning/TMVA_SOFIE_GNN_Application.C:138:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
}
^
```
The problem with `grep -v` is that it returns an non-zero error status code if nothing was found, which is a prolem if the output has no lines other than the filtered one. The test would fail because the test driver thinks something went wrong because of the non-zero status code.
ROOT first prints a newline before going over the inputs to separate printouts from the initial "root [0]" prompt. But if root is run with "-q", there is no prompt and we don't need the newline. Removing this spurious newline completely avoids all output when building ROOT, where the newline used to happen when running `hsimple.C`. This is commit is similar to 8e8b6bb, which removed another stray linebreak in the opposite case of running `root` with no input files.
We should explicitly use the Python executable from the Python version that was used to build ROOT. Otherwise, we risk picking up an different Python version at test time in some environments. This was already done on Windows before, but is important to do on all platforms. Closes root-project#21024.
Previously, when a user asked to interpolate a value close to the edges of the histogram, the function would generate an error. This is inconsistent with the TH1 version of Interpolate. Here, the valid range is extended by assuming that the histogram is constant at its edges (i.e. the imaginary next bin outside the axis limits has the same bin content as the last bin inside the limits, like in TH1). From here, the trilinear interpolation proceeds as before. Fix root-project#10678
Author
|
test parameters:
|
|
A new Pull Request was created by @smuzaffar for branch cms/master/96a77141652. @akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
Author
|
please test for CMSSW_16_1_ROOT6_X |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c1d8a/50913/summary.html Comparison SummaryThe workflows 2025.0010001, 2024.0060001, 2024.0050001 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
The idea is to find the actual ROOT install directory, so we have to follow symlinks. The `info->dlpi_name` doesn't do that, so we need to do that ourselves with `fs::canonical()`. Closes root-project#21031.
guitargeek
force-pushed
the
issue-21031
branch
from
b091755 to
5ae8259
Compare
|
Pull request #229 was updated. |
Author
|
please test |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c1d8a/50922/summary.html Failed External BuildI found compilation error when building: Requested to quit. Requested to quit. * The action "build-build-cms+dqmgui+1.0.1_R6.36.07-81057f110e660233fae09917fe2002f6" was not completed successfully because Failed to build dqmgui. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc13/cms/dqmgui/1.0.1_R6.36.07-81057f110e660233fae09917fe2002f6/log. Final lines of the log file: | ^~~~~~~ plugins/PCLPixelAlignmentRenderPlugin.cc: In member function 'void PCLPixelAlignmentRenderPlugin::preDrawTH1F(TCanvas*, const VisDQMObject&)': plugins/PCLPixelAlignmentRenderPlugin.cc:134:11: error: 'fabs' was not declared in this scope; did you mean 'labs'? 134 | if (fabs(obj->GetBinContent(i)) > maxMoveCut_[i - 1]) | ^~~~ | labs plugins/PCLPixelAlignmentRenderPlugin.cc: In member function 'void PCLPixelAlignmentRenderPlugin::postDrawTH1F(TCanvas*, const VisDQMObject&)': plugins/PCLPixelAlignmentRenderPlugin.cc:244:11: error: 'fabs' was not declared in this scope; did you mean 'labs'? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.