Enabling the use of secrets during a deployment#330
Open
karrgov wants to merge 2 commits intocloudfoundry:masterfrom
Open
Enabling the use of secrets during a deployment#330karrgov wants to merge 2 commits intocloudfoundry:masterfrom
karrgov wants to merge 2 commits intocloudfoundry:masterfrom
Conversation
...a/src/main/java/org/cloudfoundry/multiapps/mta/builders/ExtensionDescriptorChainBuilder.java
Outdated
Show resolved
Hide resolved
...a/src/main/java/org/cloudfoundry/multiapps/mta/builders/ExtensionDescriptorChainBuilder.java
Show resolved
Hide resolved
...a/src/main/java/org/cloudfoundry/multiapps/mta/builders/ExtensionDescriptorChainBuilder.java
Show resolved
Hide resolved
...c/test/java/org/cloudfoundry/multiapps/mta/builders/ExtensionDescriptorChainBuilderTest.java
Outdated
Show resolved
Hide resolved
LMCROSSITXSADEPLOY-2301
LMCROSSITXSADEPLOY-2301
karrgov
force-pushed
the
passing_secrets_during_deploy
branch
from
67c51a0 to
df93cc6
Compare
Comment on lines
+84
to
+91
|
|
||
| for(ExtensionDescriptor extensionDescriptor : localList) { | ||
| if(extensionDescriptor.getId().equals(Constants.SECURE_EXTENSION_DESCRIPTOR_ID)) { | ||
| this.secureExtensionDescriptor = extensionDescriptor; | ||
| } | ||
| } | ||
|
|
||
| for(ExtensionDescriptor extensionDescriptor : localList) { |
Contributor
There was a problem hiding this comment.
I still do not get why this whole change in collect method is needed.
Isn't it enough just to ignore the secure extension descriptor here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMCROSSITXSADEPLOY-2301