Conversation
vkalapov
force-pushed
the
bg-stop-reorder
branch
from
e8f6150 to
1408db7
Compare
Yavor16
previously approved these changes
Jan 16, 2026
LMCROSSITXSADEPLOY-3367
vkalapov
force-pushed
the
bg-stop-reorder
branch
from
1408db7 to
bb4fde3
Compare
stiv03
suggested changes
Jan 28, 2026
| util.GetShortOption(taskExecutionTimeoutOpt): "Task execution timeout in seconds", | ||
| util.CombineFullAndShortParameters(startTimeoutOpt, timeoutOpt): "Start app timeout in seconds", | ||
| util.GetShortOption(shouldBackupPreviousVersionOpt): "(EXPERIMENTAL) (STRATEGY: BLUE-GREEN, INCREMENTAL-BLUE-GREEN) Backup previous version of applications, use new cli command \"rollback-mta\" to rollback to the previous version", | ||
| util.GetShortOption(dependencyAwareStopOrderOpt): "(STRATEGY: BLUE-GREEN, INCREMENTAL-BLUE-GREEN) Stop apps in a dependency-aware order during the resume phase of a blue-green deployment", |
Contributor
There was a problem hiding this comment.
How is it guaranteed that this new flag is used only with the blue-green and incremental-blue-green strategies? Should we add validation for that and maybe a fallback for the other strategies when its wrongly used?
Contributor
Author
There was a problem hiding this comment.
I've tested with other strategy-specific parameters and the flag seems to be accepted and ignored for the operation that does not support it. In which case I think its ok to leave it without a strict failure for consistency.
I've moved the processBuilder call to deployment_strategy.go for better structural clarity and added relevant tests.
karrgov
reviewed
Jan 28, 2026
theghost5800
approved these changes
Jan 28, 2026
stiv03
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMCROSSITXSADEPLOY-3367
Description:
Issue: