Skip to content

Conversation

@stokpop
Copy link

@stokpop stokpop commented Jan 19, 2026

fixes #1138

@stokpop stokpop changed the base branch from main to feature/go-migration January 19, 2026 15:38
}

port := j.getPort()
return fmt.Sprintf("jmx=%d", port), nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are these changes related to the introduction of the cf_metrics_exporter?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I will remove this change from this PR.

Can be put in another PR if appropriate:

Background: implementing the Detect() method for cf-metrics-exporter I found that JMX returns a different kind of name than all other frameworks listed in the detected frameworks:

Detected frameworks: [Java CF Env Client Certificate Mapper Container Security Provider CF Metrics Exporter jmx=5000 Java Opts]

Changed "jmx=5000" to "JMX" as Detect returned framework name.

@rkoster rkoster requested a review from ramonskie January 20, 2026 07:38
@stokpop stokpop requested review from ramonskie and rkoster January 20, 2026 14:49
@ramonskie
Copy link
Contributor

im wondering if we need to add a integration test for this.
as we have integration tests for each of our frameworks.
something as simple does it install.

@stokpop
Copy link
Author

stokpop commented Jan 21, 2026

im wondering if we need to add a integration test for this. as we have integration tests for each of our frameworks. something as simple does it install.

@ramonskie I will have a look if I can add an integration test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CF Metrics Exporter to Java build pack

3 participants