Feature/apply organization and space quota#1330
Conversation
|
Hello, Could the build be retriggered. It failed due to an issue in downloading from maven central Error: Failed to execute goal on project cloudfoundry-client: Could not collect dependencies for project org.cloudfoundry:cloudfoundry-client:jar:6.0.0-SNAPSHOT |
|
Other builds will also have to be manually kicked off, since the Java 17 failed with the download from maven central error |
Kehrlann
left a comment
Kehrlann
left a comment
There was a problem hiding this comment.
Looks good. Thank you for your contribution!
|
|
||
| /** | ||
| * Relationships to the spaces where the quota is applied | ||
| * Use of JsonUnwrapped to inline the space relationships as per the API spec |
There was a problem hiding this comment.
[praise] Thanks for the comment, very useful!
| /** | ||
| * Links to related resources and actions for the resource | ||
| */ | ||
| @AllowNulls | ||
| @JsonProperty("links") | ||
| public abstract Map<String, Link> getLinks(); |
There was a problem hiding this comment.
[thought, non-blocking] Perhaps this should got into a common base class. AFAICT, there are links on every single API response in v3.
There was a problem hiding this comment.
Yes, typically all the responses are able to extend from Resource that contains the getLinks and a few other properties. However Resource contains a few additional fields like createdAt, updatedAt that that ApplySpaceQuotaResponse does not have as it does not return a resource. It's kind of a outliner API :)
2 participants
No description provided.