fix junit tests when jdk11 is used. #1255

[Lokowandtg]

In cloudfoundry-operations there are 32 JUnit errors when jdk 11 or jdk 17 are used. Those are fixed with this change. So far not tested with later jdks.
fixes #1255

[anthonydahanne]

please rebase on main

[anthonydahanne]

I could assert this PR fixes the 32 Junit errors on Java 17 AND Java 21. Thank you! 🙏

@Lokowandtg can you please in your branch your update the CI to :

• delete .github/workflows/ci-java-17-and-21.yml
• rename .github/workflows/ci-java-8-and-11.yml to .github/workflows/ci-java.yml
• in .github/workflows/ci-java.yml add 17, 21 to:

      matrix:
        java: [ 8, 11 ]

and then replace

      - if: ${{ matrix.java != 8 }}

with

      - if: ${{ matrix.java == 11 }}

Thanks again!

[Kehrlann]

@Lokowandtg thanks for your contribution!

I'm picking this back up.
On my own main branch, all tests in cloudfoundry-operations pass on JDK 11 ; am I missing something?

[Lokowandtg]

@Kehrlann thanks for having a look!
JDK 8 and JDK 21 worked in my setup out of main. JDK 11 and JDK 17 had the same problems in cloudfoundry-operations.
According to @anthonydahanne some merges in december fixed JDK 11 but not JDK 17. So can you test your main branch on JDK 17? Maybe I have to fix the title of this pull request.
P.S.: At the moment I am working on JDK 24 and Eclipse 2025.

[Kehrlann]

I've tried locally, and as Anthony pointed out, it works fine 🎉

Spotless should work on JDK11+ , so I'd recommend keeping the original:

      - if: ${{ matrix.java != 8 }}

And then I'll merge this.

[Kehrlann]

Looks good, thanks for your contribution!