Fix: reconnect() not working after maxRetries exhausted#322
Merged
threepointone merged 1 commit intomainfrom Feb 9, 2026
Merged
Fix: reconnect() not working after maxRetries exhausted#322threepointone merged 1 commit intomainfrom
reconnect() not working after maxRetries exhausted#322threepointone merged 1 commit intomainfrom
Conversation
Fix a bug where reconnect() could not start a new connection after maxRetries was exhausted because _connectLock was not released in _connect(). Set _connectLock = false on the early return when max retries are reached. Added a test (reconnecting.test.ts) that reproduces the issue and verifies reconnect() works after retries are exhausted, and included a changeset entry documenting the patch.
🦋 Changeset detectedLatest commit: 5383192 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Feb 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes cloudflare/partykit#252 — calling
ws.reconnect()aftermaxRetrieshas been exhausted now correctly resets and initiates a new connection.Problem
In
_connect(), whenmaxRetriesis reached, the method acquires_connectLock = truebut returns early without releasing it. This leaves the lock permanently held, so any subsequent call toreconnect()(which resets_retryCountand calls_connect()) silently bails out at the lock check — making it impossible to manually reconnect after automatic retries are exhausted.This is a common scenario when a user wants to force a reconnection on window focus after the tab has been inactive and retries have been spent.
Fix
Release
_connectLockbefore the early return in themaxRetriesguard inside_connect():if (this._retryCount >= maxRetries) { this._debug("max retries reached", this._retryCount, ">=", maxRetries); + this._connectLock = false; return; }Test plan