Check for hibernated websocket connections

[francescov1]

When using the Agents SDK along with hibernated websockets, partyserver indiscriminately tries to broadcast messages to all connections (from ctx.getWebSockets()), including foreign hibernated sockets accepted via ctx.acceptWebSocket(). Those sockets dont have partyserver's __pk attachment metadata, so reading connection.id throws the following error:

TypeError: Cannot read properties of undefined (reading 'id')
    at WebSocket.get (index.js:119299:38)
    at AgentSessionImpl.broadcast (index.js:119692:117)
    at AgentSessionImpl._setStateInternal (index.js:120183:10)
    at AgentSessionImpl.setState (index.js:120204:10)
    at AgentSessionImpl.ensureOpenCodeSession (index.js:211076:10)
    at async AgentSessionImpl.saveAndSendPrompt (index.js:211898:33)
    at async AgentSessionImpl.handleAgentSessionCreated (index.js:211789:5)

This PR adds logic to detect whether a WebSocket has PartyServer’s __pk attachment and skips non-PartyServer sockets . Also ignores non-PartyServer sockets in webSocketMessage/webSocketClose/webSocketError so we never attempt to rehydrate them into a Connection.

tryGetPartyServerMeta can probably be refined, not too familiar with this repo

[changeset-bot]

🦋 Changeset detected

Latest commit: 7eccf4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
partyserver	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[threepointone]

brother what on earth is this PR

[francescov1]

@threepointone pls read the description, it fixes a bug from using the Agents SDK with hibernated websockets

[threepointone]

Looks good, dropped a couple of comments on code that probably shouldn't be there. Let's run CI on this

[threepointone]

Why this

[francescov1]

needed to get native rolldown bindings to build locally on Mac (npm run build). Can remove if youd like

[francescov1]

looks like it broke CI, Ill remove it

[threepointone]

why this

[francescov1]

removed

[threepointone]

could you revert the changes to package-lock.json as well please?

[francescov1]

@threepointone done

[threepointone]

/oc review

[opencode-agent]

PR Review Summary

This PR fixes a real issue when using PartyServer alongside the Agents SDK with hibernated WebSockets. The problem occurs when user code calls ctx.acceptWebSocket() directly (outside PartyServer), creating WebSockets that lack PartyServer's __pk attachment metadata. When PartyServer then tries to broadcast or iterate connections, accessing connection.id throws because __pk is undefined.

What the PR does:

1. Adds tryGetPartyServerMeta() (connection.ts:41-67) - Safely extracts PartyServer metadata from a WebSocket by directly calling deserializeAttachment() and validating the __pk structure exists with proper id and server strings.

2. Adds isPartyServerWebSocket() (connection.ts:70-72) - Simple predicate wrapping tryGetPartyServerMeta().

3. Filters foreign sockets in iteration (connection.ts:218-221) - HibernatingConnectionIterator.next() now skips sockets without __pk metadata.

4. Filters in getCount() (connection.ts:304-312) - Only counts PartyServer-managed sockets.

5. Filters in getConnection() (connection.ts:316-327) - Filters by matching __pk.id instead of relying solely on tags.

6. Guards in lifecycle handlers (index.ts:429-431, 460-462, 485-487) - webSocketMessage, webSocketClose, and webSocketError now early-return for non-PartyServer sockets.

7. Adds a test (index.test.ts:152-191) with a Mixed server class (worker.ts:65-94) that demonstrates the scenario.

Code quality:

• ✅ Tests pass (9/9)
• ✅ Type checking passes
• ✅ Linting passes
• ✅ Formatting correct
• ✅ Good defensive coding with try/catch around deserialization
• ✅ Clear, descriptive comments explaining the reasoning

Minor suggestions:

1. tryGetPartyServerMeta could be simplified - The nested object validation is verbose but correct. Consider using a type guard pattern:

   function hasPartyServerMeta(attachment: unknown): attachment is ConnectionAttachments {
     return attachment !== null 
       && typeof attachment === "object"
       && "__pk" in attachment
       && /* ... */;
   }

2. Performance consideration - getCount() now iterates all sockets calling deserializeAttachment() on each. For DOs with many connections, this could be slower than before. However, this is likely acceptable since getCount() isn't typically called in hot paths.

3. Missing changeset - The bot flagged this. If this should trigger a patch release, a changeset should be added.

Verdict

Approve with minor suggestion: The PR correctly solves a real interoperability issue with proper defensive coding and good test coverage. The implementation is sound. The only actionable item is adding a changeset if a version bump is desired.

opencode session  |  github run

[threepointone]

using this PR to sneak in some test fixes