chore: remove redundant initialize code and blockConcurrencyWhile#260
Merged
threepointone merged 4 commits intocloudflare:mainfrom Feb 9, 2026
Merged
Conversation
BlankParticle
changed the title
threepointone
force-pushed
the
chore/remove-redundant-code
branch
from
e3a4a69 to
3801b5e
Compare
🦋 Changeset detectedLatest commit: 5e685b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
force-pushed
the
chore/remove-redundant-code
branch
from
7774e60 to
3ed172e
Compare
Add tests for a hibernating server that verify setName/onStart initialization behavior: onStart runs before processing connections, runs only once with concurrent connections/requests, and that websocket messages work after initialization. Implement HibernatingOnStartServer (hibernate: true) with a delayed onStart that increments a counter, plus onConnect/onMessage/onRequest handlers that expose the counter. Update tests/worker imports and wrangler.toml to register the new Durable Object binding and include it in migrations.
Introduce an AlarmServer Durable Object and test to verify that alarms initialize the DO and call onAlarm without redundant blockConcurrencyWhile. Changes: add AlarmServer class (hibernate:true) with counter and alarmCount, implement onStart/onAlarm/onRequest; export AlarmServer in the test Env; import runDurableObjectAlarm and add a test that schedules an alarm, triggers it via runDurableObjectAlarm, and asserts onStart and alarmCount behavior; register AlarmServer in wrangler.jsonc. This ensures alarm-triggered initialization works as expected.
threepointone
force-pushed
the
chore/remove-redundant-code
branch
from
3ed172e to
5e685b7
Compare
This was referenced Feb 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.