-
Notifications
You must be signed in to change notification settings - Fork 354
feat: realtime agents #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
what is this PR? can you describe in detail? also remove all the pnpm lockfiles |
feat: realtime agents example feat: store conversations in do sql fix: move realtime agent from staging to prod chore: remove old code
|
Thanks for putting this together. The core idea is solid, but this PR needs more work before it's ready to merge. Here are the main concerns: Missing FundamentalsNo tests - A feature of this complexity needs test coverage. At minimum: pipeline validation, transcript persistence, and the WebSocket message handling. No client example - The example shows the server-side agent, but how does someone actually connect to it? There's no frontend code showing how to join a RealtimeKit meeting and interact with the agent. No dependencies in package.json - The example imports from Configuration Issues
Code Quality
Missing Exports
Documentation Issues
Hardcoded ValuesThe example has hardcoded internal values that won't work for anyone else:
Recommendation: This needs another pass. Please add tests, fix the bugs, clean up the example to use placeholder values, and either add a client-side example or document how users are expected to connect to the agent. |
threepointone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking
Adds a new RealtimeAgent class (packages/agents/src/realtime/realtime-agent.ts) to orchestrate the backend realtime pipeline for voice-first agents.
Extras
Docs: @docs/realtime-agents.md
Example @examples/realtime-agent/src/index.ts