-
Notifications
You must be signed in to change notification settings - Fork 426
feat(ui): Special handling of offline_access scope in OAuth Consent screen
#7627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Filter out offline_access from displayed scopes list as it describes duration of access rather than what can be accessed - When offline_access scope is present, append text after redirect info: 'You'll stay signed in until you sign out or revoke access.' - Update sandbox to include requires_consent property and handle offline_access description appropriately for testing Part of [USER-4333](https://linear.app/clerk/issue/USER-4333/oauth-app-offline-access-scope-is-missing)
|
Cursor Agent can help with this pull request. Just |
🦋 Changeset detectedLatest commit: 462f4be The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
offline_access scope in OAuth Consent screen
📝 WalkthroughWalkthroughThis pull request adds support for the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
jacekradko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We need to add some tests for the OAuthConsent component in the future though
Agree. Thanks @jacekradko |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Description
This PR introduces special handling for the
offline_accessOAuth scope on the consent screen.See discussion.
The
offline_accessscope is now:The sandbox environment has been updated to facilitate testing of these changes.
Part of USER-4333
With

offline_access:Without

offline_access:Sandbox demo URL:
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.