This repository was archived by the owner on Sep 23, 2025. It is now read-only.
Only delete duplicate if it duplicates both combo and action#193
Open
jbrecht wants to merge 2 commits intochieffancypants:masterfrom
Open
Only delete duplicate if it duplicates both combo and action#193jbrecht wants to merge 2 commits intochieffancypants:masterfrom
jbrecht wants to merge 2 commits intochieffancypants:masterfrom
Conversation
Owner
|
Are there valid use-cases where different callbacks are used for different actions? |
Author
|
Yes, that's why I had to create this. As I said in the description, you may want to bind to both keyup and keydown for the same key. In our particular case, for example, when you use our drawing tool and hold down the shift key it constrains what the tool does (e.g. the rectangle tool only draws squares if shift is down) and so I need to detect when shift is pressed down and also detect when it was released. Moreover the existence of 'action' as a config field strongly implies you ought to be able to create action-specific bindings and expect them to work |
|
+1 - have the same need to bind both keyup and keydown |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate deletion introduced in a3b4b4c is over-eager, and will reduce 'duplicates' when we bind different callbacks to, say, keyup vs. keydown actions for the same combo