CFE-3635: Prototyped dnf_appstream custom promise type #117
+601
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wasn't looking at the ticket prior to implementation, likely missing things. Ticket: CFE-3653
- Improve state validation error message. - Move validation to attribute validators. - Simplify state checking logic. - Use info logging for repairs. - Remove redundant try/except blocks. - Add test and documentation files.
nickanderson
force-pushed
the
CFE-3635/master
branch
from
af7b8f4 to
568afb1
Compare
Added ability to reset/default a module as well as specify "default" for the profile or stream.
Member
Author
|
ok @larsewi 🫣 |
nickanderson
changed the title
nickanderson
force-pushed
the
CFE-3635/master
branch
from
2c33c57 to
a1d6535
Compare
larsewi
requested changes
Jan 23, 2026
| profile = attributes.get("profile", None) | ||
|
|
||
| try: | ||
| from libdnf.module import ModulePackageContainer |
Contributor
There was a problem hiding this comment.
libdnf.module.ModulePackageContainer imported but never used
| base.read_all_repos() | ||
|
|
||
| # Fill the sack (package database) | ||
| base.fill_sack(load_system_repo='auto') |
Contributor
There was a problem hiding this comment.
Assigning string to an argument of type bool
| base.fill_sack(load_system_repo='auto') | ||
|
|
||
| # Get ModulePackageContainer from sack | ||
| if hasattr(base.sack, '_moduleContainer'): |
Contributor
There was a problem hiding this comment.
Suggested change
| if hasattr(base.sack, '_moduleContainer'): | |
| if hasattr(base.sack, '_moduleContainer'): | |
| assert base.sack is not None |
if you are certain that it is not None. Otherwise, check for None
| f"dot, and dash characters are allowed." | ||
| ) | ||
|
|
||
| def validate_promise(self, promiser, attributes, meta): |
Contributor
There was a problem hiding this comment.
Parameter 4 name mismatch: base parameter is named "metadata", override parameter is named "meta".
Suggested change
| def validate_promise(self, promiser, attributes, meta): | |
| def validate_promise(self, promiser, attributes, metadata): |
|
|
||
| self._validate_module_name(promiser) | ||
|
|
||
| def evaluate_promise(self, promiser, attributes, meta): |
Contributor
There was a problem hiding this comment.
Parameter 4 name mismatch: base parameter is named "metadata", override parameter is named "meta".
Suggested change
| def evaluate_promise(self, promiser, attributes, meta): | |
| def validate_promise(self, promiser, attributes, metadata): |
| else: | ||
| self.log_error(f"Failed to enable module {module_name}:{target_stream}") | ||
| return Result.NOT_KEPT | ||
| except Exception as e: |
Contributor
There was a problem hiding this comment.
What exception do you expect here? Please don't handle all exceptions.
| else: | ||
| self.log_error(f"Failed to disable module {module_name}") | ||
| return Result.NOT_KEPT | ||
| except Exception as e: |
Contributor
There was a problem hiding this comment.
What exception do you expect here? Please don't handle all exceptions.
Comment on lines
+316
to
+319
| if not profile: | ||
| profile = self._get_default_profile(mpc, module_name, stream) | ||
|
|
||
| if not profile: |
Contributor
There was a problem hiding this comment.
Suggested change
| if not profile: | |
| profile = self._get_default_profile(mpc, module_name, stream) | |
| if not profile: | |
| if not profile: | |
| profile = self._get_default_profile(mpc, module_name, stream) |
| try: | ||
| base.remove(pkg) | ||
| # dnf.exceptions.Error catches package not installed, etc. | ||
| except dnf.exceptions.Error as e: |
Contributor
There was a problem hiding this comment.
exceptions is not a known attribute of module dnf
| # state => "default"; | ||
| # } | ||
|
|
||
| import dnf |
Contributor
There was a problem hiding this comment.
Missing import
Suggested change
| import dnf | |
| import dnf | |
| import dnf.exceptions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't looking at the ticket prior to implementation, likely missing things.
Ticket: CFE-3635