Task: add default event handler in task.shell()#252
Open
brianpkelly wants to merge 1 commit intocea-hpc:masterfrom
Open
Task: add default event handler in task.shell()#252brianpkelly wants to merge 1 commit intocea-hpc:masterfrom
brianpkelly wants to merge 1 commit intocea-hpc:masterfrom
Conversation
Collaborator
|
Thanks for this pull request but this bug should not be fixed that way. The bug only appears when using the new gateway code. The proper fix is more removing event handler checks in |
Author
|
Ah OK, I wasn't sure whether an event handler was necessary or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bug I ran into as detailed in this thread from the mailing list.