Skip to content

fix: nullable types added to signatures #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiei merged 2 commits into from
Jan 30, 2026
Merged

fix: nullable types added to signatures #521

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a7c8d7
fix: nullable types added to signatures
yzh-pelle Jan 30, 2026
84b9dda
fix: rollingWindowPriceChange signature updated
yzh-pelle Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions php-binance-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ public function cancelOpenOrders(string $symbol, array $params = [])
* @return array with error message or array of orderDetails array
* @throws \Exception
*/
public function orders(string $symbol, ?int $limit = null, int $fromOrderId = null, array $params = [])
public function orders(string $symbol, ?int $limit = null, ?int $fromOrderId = null, array $params = [])
{
$request = [
"symbol" => $symbol,
Expand Down Expand Up @@ -1316,7 +1316,7 @@ public function tradingDay(?string $symbol = null, ?array $symbols = null, array
* @return array with error message or array of prevDay change
* @throws \Exception
*/
public function rollingWindowPriceChange(?string $symbol = null, array $symbols = null, string $windowSize = null, array $params = [])
public function rollingWindowPriceChange(?string $symbol = null, ?array $symbols = null, ?string $windowSize = null, array $params = [])
{
$request = [];
if (!is_null($symbol) && is_string($symbol)) {
Expand Down Expand Up @@ -2058,7 +2058,7 @@ public function sorOrder(string $side, string $symbol, $quantity, $price, string
* returns array containing the response
* @throws \Exception
*/
public function replaceOrder(string $side, string $symbol, $quantity, $price, string $type = "LIMIT", ?string $cancelOrderId = null, string $cancelOrigClientOrderId = null, bool $allowFailure = null, string $cancelRestrictions = null, string $orderRateLimitExceededMode = null, array $params = [])
public function replaceOrder(string $side, string $symbol, $quantity, $price, string $type = "LIMIT", ?string $cancelOrderId = null, ?string $cancelOrigClientOrderId = null, ?bool $allowFailure = null, ?string $cancelRestrictions = null, ?string $orderRateLimitExceededMode = null, array $params = [])
{
$request = $this->createSpotOrderRequest($side, $symbol, $quantity, $price, $type, $params);
if (!is_null($cancelOrderId)) {
Expand Down
Loading