Prevent warnings if SDO setup fails#590
Merged
sveinse merged 2 commits intocanopen-python:masterfrom Jun 18, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
acolomb
approved these changes
Jun 16, 2025
Member
acolomb
left a comment
There was a problem hiding this comment.
Nice find and looks like an appropriate fix. Just one minor, optional suggestion.
Co-authored-by: André Colomb <github.com@andre.colomb.de>
Member
|
Seems like merging was allowed for you in this case. I didn't change anything though since the last PR. Hope it stays OK now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test_block_download_not_supportedis creating warnings from pytestcanopen/test/test_local.py
Lines 48 to 55 in 7ddb19b
This PR fixes the issue. The problem was 2-fold.
SdoServer.block_download()handles by sending an SDO abort. However, sending the abort fails, becauseSdoServer.abort()requiresself._indexandself._subindex.BlockDownloadStream(), but it doesn't get to initialize fully before the effort is aborted. When the object is closed, it fails as it's left in limbo.