Type annotate everywhere Network is used

[sveinse]

To finalize #511 this PR implements type annotations for Network everywhere in the codebase, making typing of Nework feature complete. Network is a central object and it makes development much easier when the (typing) references are resolvable everywhere.

[acolomb]

I must have neglected to actually send this review last night...

One thing regarding the API, otherwise just styling hints. In the hope that we will soon in sync regarding style rules... 😉 My helpers are mostly just flake8 and sometimes black for guidance. Just in case you want to let those run in the background of your IDE as well.

[acolomb]

Suggested change

	import canopen.network
	import canopen.network

[sveinse]

The following code is not a class so it's strictly not needed to have two lines according to black. Is your preference to always have two spaces below imports?

(PS! Can I encourage you to write a coding guideline document? It certainly would lessen your need to review and comment on styling.)

[acolomb]

Is your preference to always have two spaces below imports?

Yes.

Sorry I won't have much time to invest for documentation in the coming weeks I'm afraid. Hope it gets better soon.

[acolomb]

We could leave this unmerged and try to get #518 done first. Then this PR will be a perfect test case to see actual reductions in the mypy errors list.

[sveinse]

Would you be so kind to share your flake8 settings? I normally don't use flake8 (*), and if I use it out of box it only complains about "line too long" from network.py. It would help to have the same settings so I can get these formatting

(*) I use pylance/pyright (as a part of VSCode), mypy and occasionally ruff and isort. Some projects use black rigorously

[acolomb]

Nothing special, just a more convenient line length. This is my .flake8 at the project root. Couldn't get it to work with these settings in pyproject.toml when I tried.

[flake8]
max-line-length = 96
inline-quotes = "

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
canopen/objectdictionary/eds.py	60.00%	1 Missing and 1 partial ⚠️
canopen/sync.py	60.00%	1 Missing and 1 partial ⚠️
canopen/timestamp.py	60.00%	1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!