Fix some type checker errors in network module#534
Merged
acolomb merged 3 commits intocanopen-python:masterfrom Aug 14, 2024
Merged
Fix some type checker errors in network module#534acolomb merged 3 commits intocanopen-python:masterfrom
acolomb merged 3 commits intocanopen-python:masterfrom
Conversation
The attribute is set within the method directly following. So there is no need to initialize it to None before, only to confuse type checkers.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #534 +/- ##
==========================================
- Coverage 71.10% 71.04% -0.06%
==========================================
Files 26 26
Lines 3111 3112 +1
Branches 526 527 +1
==========================================
- Hits 2212 2211 -1
- Misses 769 770 +1
- Partials 130 131 +1
|
erlend-aasland
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains fixes from #512 as well, but with a slightly simpler approach.