Add missing aborts and typehints for sdoclient#352
Add missing aborts and typehints for sdoclient#352samsamfire wants to merge 6 commits intocanopen-python:masterfrom
Conversation
Also synchronous RPDOs should now be transmitted on sync reception Need to add more tests for this last part
…#345) * Fixed incorrect min (LowLImit) and max (HighLimit) values when using signed integer types. * Fixed min/max for non-signed datatypes and added tests * Removed type hints
-adding typehints -adding some missing sdo aborts (timeout, unknown command)
This reverts commit 074be34.
|
reverting the PDO change that has nothing to do with this PR |
|
@samsamfire Sorry for not responding for such a long time. I've tried to grasp your changes here in order to see if there's merit in merging it for the next release. However, it is quite convoluted between actual changes and formatting. Would you mind separating those into several smaller PRs or at least split into independent commits? |
|
Keeping this open because the functional change regarding SDO aborts could be worthwhile. But as is, this is too convoluted to act upon. Someone should pick up the gist of it and redo another, focused PR. |
|
I think this makes sense. Once the formatting and type hints are shaved off, the changes aren't really that big. Getting them stripped down to pure functional changes should be done, yes. |
|
Should we close this in favor of #594 now? I haven't checked all details, there might be some other worthwhile improvements in here. But it's cumbersome to extract them. |
5 participants
Hi,
I found some missing aborts whilst doing some tests:
in particular, an sdo abort should be sent when a timeout occurs (0x05040000)
an abort should also be sent if the expected command value is not correct (0x05040001).
I also added typehints were possible.
Also, have any of you considered to add a static type checker (mypy,...) and a linting tool ? Could be good in the future