remove python-can >=v4.0.0 as dependency#318
remove python-can >=v4.0.0 as dependency#318VonSquiggles wants to merge 1 commit intocanopen-python:masterfrom
Conversation
|
What bugs exactly are you talking about? What is it that breaks? Are these maybe fixed by now so we could upgrade the dependency to a known good version of python-can? |
|
I don't recall the specific issues I was having, but Python-can v4 has several API changes, and the latest release on this repo is based on v3 API. There are plenty of known good versions of python-can v3 that you can use (looks like 3.3.4 is latest) |
|
I guess you are talking about the issues mentioned in #296? If there are others, could you please test again to pinpoint them? Disallowing python-can >= 4.0.0 as a dependency is not a good option for the majority of the user-base. Since we only require >= 3.0.0, you can pin the last working version from that branch easily for your use-case, until the underlying bug in python-can (hardbyte/python-can#1285) is fixed. Thus I'd lean toward closing this PR. |
|
@VonSquiggles if you have problems with the Ixxat interface, a pull request in python-can would be helpful. The maintainers do not have access to the hardware. Edit: It might have been fixed in hardbyte/python-can#1141 |
|
@zariiii9003, @VonSquiggles
however this issue is solved with the pull request hardbyte/python-can#1532 |
Bugs in python-can v4.0.0 break the API. Remove as dependency option until bugs are fixed.