Add Missing Dependencies to @haul-bundler/babel-preset-react-native#768
Open
Stuart-Wilcox wants to merge 3 commits intocallstack:masterfrom
Open
Add Missing Dependencies to @haul-bundler/babel-preset-react-native#768Stuart-Wilcox wants to merge 3 commits intocallstack:masterfrom
Stuart-Wilcox wants to merge 3 commits intocallstack:masterfrom
Conversation
… @haul-bundler/babel-preset-react-native
…-bundler/babel-preset-react-native
Stuart-Wilcox
changed the title
Stuart-Wilcox
changed the title
Stuart-Wilcox
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing dependencies @babel/plugin-transform-computed-properties to @haul-bundler/babel-preset-react-native.
The following dependencies are used in @haul-bundler/babel-preset-react-native
However they are not declared in the dependencies of package.json for @haul-bundler/babel-preset-react-native.
I have encountered errors while trying to use this in a non-hoisted environment, and I believe this was working previously due to hoisting.
Test plan
This should not affect anything, the dependency was likely being resolved previously due to hoisting, and it is simply now being explicitly declared