Skip to content

Conversation

@PeerRich
Copy link
Member

What does this PR do?

Refactors the organization members page from /settings/organizations/members to /members and adds a permanent redirect from the old path to the new one.

Changes:

  • Creates new /members route under the main navigation shell
  • Adds permanent redirect from /settings/organizations/members/members in next.config.ts
  • Includes loading skeleton and server actions for cache revalidation

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no documentation changes needed.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Navigate to /members as an organization member - should see the organization members list
  2. Navigate to /settings/organizations/members - should be permanently redirected to /members
  3. Navigate to /members as a non-organization user - should be redirected to /settings/my-account/profile

Human Review Checklist

  • Verify the new /members route renders correctly with the ShellMainAppDir wrapper (different from the old settings layout)
  • Confirm the permanent redirect (HTTP 308) works correctly
  • Decide if the old page at /settings/organizations/(org-user-only)/members/ should be removed to avoid code duplication
  • Verify authorization checks work correctly for org vs non-org users

Checklist

  • My code follows the style guidelines of this project
  • I have checked if my changes generate no new warnings

Link to Devin run: https://app.devin.ai/sessions/1c631bb483b3481ba3af1eedcd509fda
Requested by: @PeerRich

…/members to /members

- Create new /members route under main-nav with same functionality
- Add permanent redirect from /settings/organizations/members to /members
- Include loading skeleton and server actions for the new route

Co-Authored-By: peer@cal.com <peer@cal.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants