Skip to content

SIMD: Add i64x2.all_true, i64x2.eq, i64x2.ne#212

Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom
yurydelendik:bug1688380
Feb 4, 2021
Merged

SIMD: Add i64x2.all_true, i64x2.eq, i64x2.ne#212
alexcrichton merged 2 commits intobytecodealliance:mainfrom
yurydelendik:bug1688380

Conversation

@yurydelendik
Copy link
Contributor

@yurydelendik yurydelendik commented Jan 27, 2021 •
edited
Loading

See WebAssembly/simd#381, WebAssembly/simd#411, WebAssembly/simd#415. These have been accepted into the spec.

TODO:

  • binary encodings for i64x2.eq and i64x2.ne

@yurydelendik yurydelendik changed the title Add i64x2.all_true, i64x2.eq, i64x2.ne SIMD: Add i64x2.all_true, i64x2.eq, i64x2.ne Jan 27, 2021
@yurydelendik
Copy link
Contributor Author

yurydelendik commented Jan 27, 2021

atm selecting 0xfd c0 for "i64x2.eq" (based on the code in binaryen), and 0xfd c2 for "i64x2.ne"

alexcrichton
alexcrichton approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should merging hold off though until the upstream opcodes are assigned numbers?

@yurydelendik
Copy link
Contributor Author

yurydelendik commented Jan 27, 2021

Should merging hold off though until the upstream opcodes are assigned numbers?

Probably. I think 0xfd c0 will stay, not sure about other one. @lars-t-hansen ?

@lars-t-hansen
Copy link
Contributor

lars-t-hansen commented Jan 28, 2021

i64x2.all_true also appears to be a mess: WebAssembly/simd#415 (comment), a consequence of insisting on "logical" blocks of instructions while not setting aside large enough open spaces, combined with a bug in V8 that disallows opcodes > 255.

@alexcrichton
Copy link
Member

alexcrichton commented Jan 28, 2021

Well in any case y'all are much more up-to-date on simd than I am anyway, so I'm happy to merge whenever y'all are comfortable about the opcodes.

@yurydelendik
Copy link
Contributor Author

yurydelendik commented Feb 4, 2021

encoding from https://chromium.googlesource.com/v8/v8.git/+/refs/heads/master/src/wasm/wasm-opcodes.h#350

@yurydelendik yurydelendik marked this pull request as ready for review February 4, 2021 00:16
@alexcrichton alexcrichton merged commit 7433b4b into bytecodealliance:main Feb 4, 2021
@yurydelendik yurydelendik mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yurydelendik @lars-t-hansen @alexcrichton