IAM policies on Secret Manager on single Elastic CI Stack note #2161
Open
IAM policies on Secret Manager on single Elastic CI Stack note #2161
Conversation
…e CI stack setups
|
Your Render PR Server URL is https://bk-docs-pr-2161.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-chqmav8rddleuf4glg9g. |
Comment on lines
+49
to
+50
| >📘 Single instance Elastic CI Stacks | ||
| > If you have set `minSize` and `maxSize` parameters equal to 1 in your [Elastic CI Stack parameters](/docs/agent/v3/elastic-ci-aws/parameters), you will only need to set the `IAMRole` to your Secret Manager secret's resource policy as above. The `AutoscalingLambdaExecutionRole` IAM role and corresponding autoscaling resources are not created in this Elastic CI Stack setup. |
Contributor
There was a problem hiding this comment.
I think this is a little simpler/clearer:
Suggested change
| >📘 Single instance Elastic CI Stacks | |
| > If you have set `minSize` and `maxSize` parameters equal to 1 in your [Elastic CI Stack parameters](/docs/agent/v3/elastic-ci-aws/parameters), you will only need to set the `IAMRole` to your Secret Manager secret's resource policy as above. The `AutoscalingLambdaExecutionRole` IAM role and corresponding autoscaling resources are not created in this Elastic CI Stack setup. | |
| >📘 Single instance stacks | |
| > If you have set `minSize` and `maxSize` [parameters](/docs/agent/v3/elastic-ci-aws/parameters) equal to `1`, don't include the `AutoscalingLambdaExecutionRole` IAM role in the resource policy. Only the `IAMRole` is required since this setup doesn't need autoscaling resources. |
But it's a little less precise, so happy to go with your version if you think it works better. Let me know what you think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
docs/pages/agent/v3/aws/secrets_manager.mdpage (Storing agent tokens) to clarify the need for only one IAM role to be set in a corresponding secret's policy.