Fix arithmetic expression crash in project-install.sh #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script crashed with `set -e` due to post-increment returning exit code 1 when chain_depth was 0. Changed to pre-increment so expression always returns non-zero value.
Perlover
changed the title
|
Similar implementation to #312 |
Replace post-increment ((var++)) with pre-increment ((++var)) to prevent script termination when using set -e. In bash, ((expr)) returns exit code 1 when the expression evaluates to 0, which happens with post-increment when the variable is 0. This fix ensures all commands are installed correctly instead of only the first one.
|
I confirm that without @Perlover changes i wasn't able to run project-install.sh on my ubuntu 24.04.3. |
otavio
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix arithmetic expression crash in project-install.sh
Script crashed with
set -edue to post-increment returning exit code 1when chain_depth was 0. Changed to pre-increment so expression always
returns non-zero value.
#311