Update from Bitcoin-ruby repo#1
Merged
jgmontoya merged 10 commits intobudacom:masterfrom Feb 17, 2023
Merged
Conversation
This is often bundled with ruby, but not always.
No more warnings, yay.
macos is disabled for now, as it's crashy, as per patch trigger.
LibreSSL uses a mostly OpenSSL 1.0.1 compatible API, with the alarmingly notable exception of the version API. When the library is loaded on macOS with LibreSSL the verison check introduced in lian#42 the gem was incompatible with LibreSSL. This change may not be ideally forward-compatible if APIs change and may need a new strategy eventually, but is not noticeably weaker than the version based strategy. It is notably functional on both macOS with LibreSSL 2.8.3, as well as remaining compatible with OpenSSL 1.1.1f on Ubuntu.
On macOS the library load is handled in a specific and incompatible way, which is handled by the extension. As the gem uses the extension elsewhere, taking a direct dependency on that, and looking up symbols from in-process should be safe and sufficient.
jgmontoya
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Just copying lian#311 PR to this repo