Merged
Conversation
- Add lock_path parameter to OpenSerial.__init__ - Default to /tmp/serial.lock or NOTECARD_SERIAL_LOCK_PATH env var - Fix docstring formatting Fixes #63 Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make FileLock path configurable
This PR addresses issue #63 by making the FileLock path configurable in the OpenSerial class:
Testing
Link to Devin run: https://app.devin.ai/sessions/5127404bd9bf4bb3a043924f0e975461
Fixes #63