feat: add simple idiomatic file upload capability#64
Merged
Conversation
rayozzie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also:
https://github.com/blues/hub/pull/7066
https://github.com/blues/notecard/pull/1270
This PR adds a mechanism that can be used for simple and high-performance file uploading. It is a specific goal that the golang file implementing this will be treated as the idiomatic implementation, so that others may look at it and re-code it into their language of choice.
Three new arguments are added to the notecard utility:
Cannot be merged until
a) note-go is merged from hub branch
b) note-go has been pushed to the public repo
c) the temporary copy of note-go is deleted from this branch, and
d) the 'replace' directive for note-go is eliminated from go.mod
e) the bin's are 'published' and the notecard utility can be downloaded & run from a Raspberry Pi