Allow overriding max parameter length from the default of 500#26
Open
neilberget wants to merge 1 commit intobleacherreport:masterfrom
Open
Allow overriding max parameter length from the default of 500#26neilberget wants to merge 1 commit intobleacherreport:masterfrom
neilberget wants to merge 1 commit intobleacherreport:masterfrom
Conversation
Author
|
Thought I'd try to share this back in case you find this useful. |
scrogson
suggested changes
Apr 9, 2019
Contributor
scrogson
left a comment
scrogson
left a comment
There was a problem hiding this comment.
Thanks for this PR!
A couple of things that would help get this PR merged:
- Remove the additions outlined in the comments. This will help avoid merge conflicts. We'll update those when we're ready to publish a new version.
- Please add a simple test that shows this functionality in action.
Thanks again! ❤️
|
|
||
| ## Master | ||
|
|
||
| ## 0.7.0 |
Contributor
There was a problem hiding this comment.
Can you remove this from the PR? We'll update this when we are ready to publish a new version.
| ```elixir | ||
| def deps do | ||
| [{:plug_logger_json, "~> 0.6.0"}] | ||
| [{:plug_logger_json, "~> 0.7.0"}] |
Contributor
There was a problem hiding this comment.
Can you remove this from the PR? We'll update this when we are ready to publish a new version.
| start_permanent: Mix.env == :prod, | ||
| test_coverage: [tool: ExCoveralls], | ||
| version: "0.6.0", | ||
| version: "0.7.0", |
Contributor
There was a problem hiding this comment.
Can you remove this from the PR? We'll update this when we are ready to publish a new version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows overriding the maximum length of parameters that are logged from the default of 500.