add pool_timeout and max_connections parameters#11
add pool_timeout and max_connections parameters#11lcx wants to merge 2 commits intobklang:developfrom
Conversation
There was a problem hiding this comment.
Tiny nit, but would you please add spaces after the commas?
There was a problem hiding this comment.
Also, it occurs to me that it might be better to pass this as a hash to #establish_connection, in case we get more params in the future. The calling code would then look something like
@@connection = establish_connection connection_string(params), max_connections: max_connections, pool_timeout: pool_timeout
|
A few code nits, but thank you for your contribution! |
|
Odd, no idea why I used ruby 1.8 syntax, I occasionally do that :) |
|
There are a lot of adapter specific connection options[1], so I'm wondering if it wouldn't make sense to take a [1] http://sequel.jeremyevans.net/rdoc/files/doc/opening_databases_rdoc.html |
Added configuration option for pool_timeout and max_connections to pass over to sequel