Skip to content

[PM-31745] Allow user to perm delete unassigned items#6956

Open
Jingo88 wants to merge 3 commits intomainfrom
PM-31745-unassigned-items-delete
Open

[PM-31745] Allow user to perm delete unassigned items#6956
Jingo88 wants to merge 3 commits intomainfrom
PM-31745-unassigned-items-delete

Conversation

@Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Feb 5, 2026

🎟️ Tracking

PM-31745

📔 Objective

Update the DeleteAdmin Task to use GetByIdAsyncAdmin so unassigned ciphers can be returned.

📸 Screen Recording

PM-31745-unassign-delete.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Jingo88 Jingo88 requested a review from a team as a code owner February 5, 2026 21:11
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Logo
Checkmarx One – Scan Summary & Detailsee218ffb-0f73-4834-8c6e-7a803fcc1bfc

New Issues (2)

Checkmarx found the following issues in this Pull Request

# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 291
detailsMethod at line 291 of /src/Api/Auth/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow...
Attack Vector
2 MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 452
detailsMethod at line 452 of /src/Api/Auth/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow...
Attack Vector
Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 145

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.23%. Comparing base (67ba9bc) to head (09efa30).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6956      +/-   ##
==========================================
- Coverage   60.27%   56.23%   -4.04%     
==========================================
  Files        1982     1982              
  Lines       87653    87653              
  Branches     7816     7816              
==========================================
- Hits        52830    49293    -3537     
- Misses      32904    36530    +3626     
+ Partials     1919     1830      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants