Skip to content

Conversation

@Banrion
Copy link

@Banrion Banrion commented Feb 5, 2026

🎟️ Tracking

PM-31747

📔 Objective

This pull request adds a download route for the latest organization report, updates the RequestSizeLimit for the endpoints that save or update a report, and updates save endpoints to not attempt to return the large report data. This is to support saving reports that are too large for the current restraints.

  • Add new GET /reports/organizations/{organizationId}/latest/download endpoint that returns organization reports as downloadable JSON files to support large reports (30MB+)
  • Create OrganizationReportIdResponseModel lightweight response model returning only metadata for endpoints
    • POST /reports/organizations/{organizationId}
    • PATCH /reports/organizations/{organizationId}/data/report/{reportId}
  • Add [RequestSizeLimit(Constants.FileSize501mb)] attribute to POST and PATCH endpoints for report creation/updates
  • Add EscapeJsonString() helper method to properly escape JSON strings in download endpoint

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…ationReportSaving. Add download endpoint for risk insights report
@Banrion Banrion requested a review from prograhamming February 5, 2026 11:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Logo
Checkmarx One – Scan Summary & Details0d5f71c6-9f89-4754-a256-58ca40ebcfa5

New Issues (2)

Checkmarx found the following issues in this Pull Request

# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 291
detailsMethod at line 291 of /src/Api/Auth/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow...
Attack Vector
2 MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 452
detailsMethod at line 452 of /src/Api/Auth/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow...
Attack Vector
Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 145

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants