Fixed invalid syntax in OrganizationUser_UpdateMany

[mkincaid-bw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/DBOPS-80

📔 Objective

We found invalid SQL syntax in the OrganizationUser_UpdateMany stored procedure. Oddly, the invalid syntax does not throw an error, but it also does not perform the expected action.

    EXEC [dbo].[User_BumpManyAccountRevisionDates]
    (
        SELECT [UserId]
        FROM @OrganizationUserInput
    )

This code does not actually call User_BumpManyAccountRevisionDates, but instead simply returns the results of the SELECT statement within the parameters. I'm assuming why this has not been noticed before. This PR fixes the invalid syntax, and now the resulting call to User_BumpManyAccountRevisionDates should work as expected.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.21%. Comparing base (0159052) to head (85ec80e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6923      +/-   ##
==========================================
- Coverage   60.21%   60.21%   -0.01%     
==========================================
  Files        1976     1976              
  Lines       87536    87536              
  Branches     7810     7810              
==========================================
- Hits        52714    52713       -1     
- Misses      32907    32908       +1     
  Partials     1915     1915              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 00514c73-582c-4653-a87a-cbd160787fb7

New Issues (3)

Checkmarx found the following issues in this Pull Request

#	Severity	Issue	Source File / Package	Checkmarx Insight
1		CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 291	details Method at line 291 of /src/Api/Auth/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow... Attack Vector
2		CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1527	details Method at line 1527 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... Attack Vector
3		CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1403	details Method at line 1403 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... Attack Vector

Fixed Issues (4)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 145
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 847
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 847
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 293

[eliykat]

Bit of an odd one, thanks for fixing it.

[rkac-bw]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
96.7% Duplication on New Code

See analysis details on SonarQube Cloud