Skip to content

Refactor popUpToCompleteRegistration to use type-safe KClass reference#6480

Draft
SaintPatrck wants to merge 1 commit intomainfrom
fix-complete-registration-nav
Draft

Refactor popUpToCompleteRegistration to use type-safe KClass reference#6480
SaintPatrck wants to merge 1 commit intomainfrom
fix-complete-registration-nav

Conversation

@SaintPatrck
Copy link
Contributor

🎟️ Tracking

TBD

📔 Objective

Fixes a crash caused when popping up to the CompleteRegistrationRoute.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Fixes a crash caused when popping up to the CompleteRegistrationRoute.
@github-actions github-actions bot added the app:password-manager Bitwarden Password Manager app context label Feb 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Logo
Checkmarx One – Scan Summary & Details054d15bc-ec99-4d6f-9814-057e4e02fdd8

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.30%. Comparing base (47b9509) to head (8034188).

Files with missing lines Patch % Lines
...leteregistration/CompleteRegistrationNavigation.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6480   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files         780      780           
  Lines       56351    56351           
  Branches     8149     8149           
=======================================
  Hits        48635    48635           
  Misses       4876     4876           
  Partials     2840     2840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant