Open
Conversation
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
6c7bae9 to
3225972
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6479 +/- ##
==========================================
+ Coverage 86.30% 86.36% +0.05%
==========================================
Files 780 767 -13
Lines 56351 56018 -333
Branches 8149 8147 -2
==========================================
- Hits 48635 48381 -254
+ Misses 4876 4797 -79
Partials 2840 2840 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3225972 to
ce8cc8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎟️ Tracking
N/A
📔 Objective
This PR updates the app to use AGP v9.0.0 and Hilt v2.59.
This is a major update to AGP and this PR addresses several changes required to make it all work but there is still some amount of deprecated code that is still in use after this PR is done (baby steps).
gralde.propertiesto use new default and disable new defaults we are not yet ready for.android.newDslis currently set to false, this is the biggest one that still requires a lot of work to update.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes