[PM-28834] Set landscape orientation for specific devices#6374
Open
[PM-28834] Set landscape orientation for specific devices#6374
Conversation
github-actions
bot
added
app:password-manager
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
|
|
||
| // Set landscape orientation for Horizon OS devices | ||
| if (isHorizonOS()) { | ||
| requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE |
Collaborator
There was a problem hiding this comment.
Shouldn't this be handled by the OS?
We are supposed to let the user decide how they want to view the app.
Collaborator
There was a problem hiding this comment.
We discussed this in standup, LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6374 +/- ##
==========================================
- Coverage 85.46% 84.82% -0.65%
==========================================
Files 764 945 +181
Lines 54893 57974 +3081
Branches 7948 8048 +100
==========================================
+ Hits 46914 49174 +2260
- Misses 5223 6008 +785
- Partials 2756 2792 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SaintPatrck
reviewed
Jan 16, 2026
| installSplashScreen().setKeepOnScreenCondition { shouldShowSplashScreen } | ||
| super.onCreate(savedInstanceState) | ||
|
|
||
| // Set landscape orientation for Horizon OS devices |
Contributor
There was a problem hiding this comment.
⛏️ Would you mind elaborating on why this has to be done?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-28834
📔 Objective
Change screen orientation for landscape on specific devices
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes