[PM-29304] feat: Add custom field autofill support with strict URI matching#6243
Open
gryphon2411 wants to merge 6 commits intobitwarden:mainfrom
Open
[PM-29304] feat: Add custom field autofill support with strict URI matching#6243gryphon2411 wants to merge 6 commits intobitwarden:mainfrom
gryphon2411 wants to merge 6 commits intobitwarden:mainfrom
Conversation
Implements support for autofilling custom fields defined in vault items. Includes strict URI matching for security and regression fix for generic inputs.
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
Author
|
Hi! 👋
Looking forward to your feedback. Thanks for your time! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for autofilling custom fields defined in vault items.
Verification
I have verified this functionality using the Android Emulator (API 35) and the
standardDebugbuild.Test Case: Timewatch.co.il
https://c.timewatch.co.il/punch/punch.phphttps://c.timewatch.co.il(Strict match)12345(Employee Number)******login-comp-input, Value:comp123comp123.12345.******.Automated Tests:
FilledDataBuilderCustomFieldTest: Verifies strict matching and field mapping.AutofillParserRegressionTests: Verifies generic input promotion to Username.Context
Ref: PM-29304 (Internal Ticket)
Addresses community feature requests for Android Custom Field Autofill: