[PM-17485] [PM-16961] Fix opening vault item URLs with no scheme#4615
Open
elidrissidev wants to merge 1 commit intobitwarden:mainfrom
Open
[PM-17485] [PM-16961] Fix opening vault item URLs with no scheme#4615elidrissidev wants to merge 1 commit intobitwarden:mainfrom
elidrissidev wants to merge 1 commit intobitwarden:mainfrom
Conversation
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
#4552
📔 Objective
This PR fixes an issue where vault item URLs entered without a scheme and not starting with
//(e.g.github.com) may not open properly on some browsers. Technically this is not a bug but is due to the way URIs are parsed per the RFC, which treats the above example as a path instead of a host name. So the URL that's actually sent in the intent becomeshttps:/github.com.The proposed solution should work well with all the different ways of typing a URL:
https://github.com,//github.com, andgithub.com.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes