Skip to content

[PM-17354] feat: allow using non-numeric characters within PIN#4597

Open
mu88 wants to merge 1 commit intobitwarden:mainfrom
mu88:feature/allow-non-numeric-characters-within-PIN
Open

[PM-17354] feat: allow using non-numeric characters within PIN#4597
mu88 wants to merge 1 commit intobitwarden:mainfrom
mu88:feature/allow-non-numeric-characters-within-PIN

Conversation

@mu88
Copy link

@mu88 mu88 commented Jan 20, 2025

Relates to https://community.bitwarden.com/t/mobile-support-for-alphanumeric-pin-codes/27671

🎟️ Tracking

https://community.bitwarden.com/t/mobile-support-for-alphanumeric-pin-codes/27671

📔 Objective

As there are quite some feature requests to allow using non-numeric characters within the PIN, I thought I give it a shot and propose my desired change as a PR. Please bear with me if this violates one of your processes - I'm happy to learn and adapt 🙂

📸 Screenshots

It's just the same, just with the keyboard offering all characters.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-17354

@bitwarden-bot bitwarden-bot changed the title feat: allow using non-numeric characters within PIN [PM-17354] feat: allow using non-numeric characters within PIN Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants