[PM-17354] feat: allow using non-numeric characters within PIN#4597
Open
mu88 wants to merge 1 commit intobitwarden:mainfrom
Open
[PM-17354] feat: allow using non-numeric characters within PIN#4597mu88 wants to merge 1 commit intobitwarden:mainfrom
mu88 wants to merge 1 commit intobitwarden:mainfrom
Conversation
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://community.bitwarden.com/t/mobile-support-for-alphanumeric-pin-codes/27671
🎟️ Tracking
https://community.bitwarden.com/t/mobile-support-for-alphanumeric-pin-codes/27671
📔 Objective
As there are quite some feature requests to allow using non-numeric characters within the PIN, I thought I give it a shot and propose my desired change as a PR. Please bear with me if this violates one of your processes - I'm happy to learn and adapt 🙂
📸 Screenshots
It's just the same, just with the keyboard offering all characters.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes