Conversation
- Add .shellcheckrc with SC1091 and SC2154 disabled - Add .github/workflows/shellcheck.yml for automated shell script checking - Workflow will check any future shell scripts added to the repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds shellcheck CI to the bc-github-actions repository to catch shell script issues early. While the repository currently has no shell scripts, this ensures that any future additions will be automatically checked for common issues.
Changes
.shellcheckrcwith appropriate exclusions (SC1091, SC2154).github/workflows/shellcheck.ymlfor automated checkingConfiguration
The shellcheck workflow:
ludeeus/action-shellcheck@2.0.0(pinned version)warning(fails on warnings and errors).shfiles are executableBenefits