Skip to content

Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
tvpeter wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client #2109

tvpeter wants to merge 6 commits into from

Conversation

@tvpeter
Copy link
Contributor

@tvpeter tvpeter commented Jan 29, 2026 •
edited
Loading

Description

This PR replaces bitcoincore-rpc with bdk-bitcoind-client in bdk-bitcoind-rpc library and its dependants.

Depends on bdk-bitcoind-client#5

Notes to the reviewers

  • changed the Emitter to a concrete type
  • In the example crate, I replaced the shared client between threads with two different clients (will come back to improve this later)

Changelog notice

  • replace bitcoincore-rpc with bdk-bitcoind-client

Checklists

All Submissions:

@tvpeter tvpeter changed the title Refactor/core rpc to client lib Refactor: update bdk-bitcoind-rpc to use bdk-bitcoind-client Jan 29, 2026
@oleonardolima
Copy link
Collaborator

oleonardolima commented Jan 29, 2026 •
edited
Loading

You can rebase on top of master, so the conflicts goes away and rand-std would be under he std feature too.

@tvpeter
Copy link
Contributor Author

tvpeter commented Jan 29, 2026

You can replace on top of master, so the conflicts goes away and rand-std would be under he std feature too.

Yes, saw that the base PR has been merged. I will rebase

oleonardolima and others added 5 commits January 29, 2026 18:07
@oleonardolima @tvpeter
deps(bdk_testenv): bump electrsd to 0.36.1
012058d
@ValuedMammal @tvpeter
tests(bdk_bitcoind_rpc): add/use new ClientExit
93c7cbf 
- add `ClientExt` trait to it's own common module.
- update the `bdk_bitcoind_rpc` lib.rs tests to use `ClientExt`.
- update the `bdk_bitcoind_rpc` test_emitter.rs tests to use `ClientExt`.
- update the `bdk_bitcoind_rpc` test_filter_iter.rs tests to use `ClientExt`.
@oleonardolima @tvpeter
fix(tests): on bdk_chain
4e28d3f
@tvpeter
refactor(core-rpc): Replace rpc with client
df23b06 
- replace bitcoincore-rpc with bdk-bitcoind-client
in lib and examples
@tvpeter
refactor(core-rpc): Update tests to use client
0e506d2 
- update all tests to use bdk-bitcoind-client
@tvpeter tvpeter force-pushed the refactor/core-rpc-to-client-lib branch from d88697e to 293000d Compare January 30, 2026 00:33
@tvpeter
refactor(core-rpc): Update bitcoind_rpc dependants
454b807 
- after updating bitcoind_rpc with bdk-
bitcoind-client, the random fn became unvailable
in chain, so I enabled the rand-std feature
- also updated the random fn to use the one
available in chain through bitcoin
@tvpeter tvpeter force-pushed the refactor/core-rpc-to-client-lib branch from 293000d to 454b807 Compare January 30, 2026 00:48
@oleonardolima oleonardolima self-requested a review January 31, 2026 03:42
@oleonardolima oleonardolima added dependencies Pull requests that update a dependency file api A breaking API change labels Jan 31, 2026
@oleonardolima oleonardolima moved this to In Progress in BDK Chain Jan 31, 2026
@oleonardolima oleonardolima added this to the Chain 0.24.0 milestone Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleonardolima oleonardolima Awaiting requested review from oleonardolima

At least 1 approving review is required to merge this pull request.

Assignees

@tvpeter tvpeter

Labels

api A breaking API change dependencies Pull requests that update a dependency file

Projects

BDK Chain
Status: In Progress

Milestone

Chain 0.24.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tvpeter @oleonardolima @ValuedMammal