deps(bdk_chain)!: bump miniscript to 13.0.0
#2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleonardolima
requested review from
ValuedMammal,
evanlinjin and
notmandatory
- upgrades `miniscript` version to `13.0.0`. - fixes the usage of `psbt.sign` in `example_cli. - `miniscript/no-std` has been removed in `13.0.0`, so it's not needed anymore to use it in CI. BREAKING_CHANGE: `bdk_chain` does re-exports the `miniscript` API, therefore bumping it's version is considered a breaking change.
oleonardolima
force-pushed
the
deps/bump-miniscript-to-13.x.x
branch
from
5870b53 to
17d003a
Compare
Member
|
Looks like this needs a rebase on master to get the CI running. |
Collaborator
Author
It looks like it's already running fine, the one pending is the old jobs due to the change in this PR 🤔 |
Collaborator
Author
|
Oh, but how can we ignore them though ? The old jobs are blocking the merge. |
Member
I have special permissions 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR upgrades
miniscriptto it's latestv13.0.0, it's a breaking change so it's only meant to being merged in master, can't be backported torelease/chain-0.23.x.miniscriptversion to13.0.0.psbt.signin `example_cli.BREAKING_CHANGE:
bdk_chaindoes re-exports theminiscriptAPI, therefore bumping it's version is considered a breaking change.Notes to the reviewers
Changelog notice
Checklists
All Submissions:
New Features: