Skip to content

Conversation

@rishabhyadav03
Copy link

This PR adds a request timeout to the Esplora client used by the example application. Configuring a timeout helps avoid hanging network requests and makes the example more robust for real world usage.

Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK 0a36b0a

As also mentioned in this other comment it does not belong to the README.md. Maybe the example could use the timeout, but that would require it to be reworked to actually be an argument/parameter, instead of just setting it up straight to 60, as it's currently being done in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants