@improvement/windows-positioning#120
Open
mattiadelfranco wants to merge 4 commits intobillsonnn:devfrom
Open
Conversation
Release 2.1.1 Closes #252 See merge request nitro/nitro-react!74
Changed position type of #draggable-windows-container from absolute to fixed to getting working the z-index (now toolbars, notifications and infostand are displayed on top of windows).
billsonnn
added a commit
that referenced
this pull request
Jul 20, 2023
Fix issue #120 - Animated badges See merge request nitro/nitro-react!88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes default window positioning from center to top_left (for a desktop-first experience): this fix avoids that UI windows moves when resizing the browser window (this could potentially make impossible to view windows after a resize).
This commit improves also the window z-index by making the position of #draggable-windows-container fixed instead of absolute: now the toolbar and other UI elements like that must be always visible aren't covered anymore from the windows.